blog: add video embed to Dakota Alpha 1 post#765
blog: add video embed to Dakota Alpha 1 post#765castrojo wants to merge 3 commits intoprojectbluefin:mainfrom
Conversation
…udit questions - One branch per logical fix (never bundle unrelated changes) - Load github-actions-expert before touching any .github/workflows/ file - Call ask_user before planning on any audit task - Create .github/copilot-instructions.md pointer to AGENTS.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Closing — opened incorrectly via gh pr create. Will resubmit via compare URL per proper procedure. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Copilot instructions, updates the AGENTS.md file with new git workflow and skill requirements, and adds a YouTube video to a blog post. The review feedback correctly identifies that the PR violates the newly introduced "one branch per logical fix" rule by bundling unrelated changes. Furthermore, the YouTube iframe requires adjustments to its attributes to ensure compatibility with JSX/Docusaurus and to improve performance.
| **Never push directly to main.** Always work on a topic branch: | ||
| **Never push directly to main.** Always work on a topic branch. | ||
|
|
||
| **One branch per logical fix.** Never bundle unrelated changes onto the same branch, even if the second change is small. Each fix gets its own branch and PR — create a separate branch, cherry-pick if needed. |
There was a problem hiding this comment.
This pull request violates the "One branch per logical fix" rule being introduced in this very change. It bundles unrelated documentation updates (Copilot instructions and agent workflow rules) with a blog post update. To adhere to the repository's workflow and maintain a clean git history, these changes should be split into separate pull requests.
| tags: [announcements] | ||
| --- | ||
|
|
||
| <iframe width="560" height="315" src="https://www.youtube.com/embed/UzhMA2Mw3Bc?si=a6PtI-QUnFFyhvIB" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe> |
There was a problem hiding this comment.
The <iframe> uses HTML attributes that are incompatible with JSX, which Docusaurus uses for rendering Markdown. Attributes like frameborder, referrerpolicy, and allowfullscreen must be camelCased as frameBorder, referrerPolicy, and allowFullScreen to avoid React warnings and potential build failures in a strict CI environment. Additionally, it is recommended to remove the si tracking parameter from the YouTube URL and add loading="lazy" for better performance.
| <iframe width="560" height="315" src="https://www.youtube.com/embed/UzhMA2Mw3Bc?si=a6PtI-QUnFFyhvIB" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe> | |
| <iframe width="560" height="315" src="https://www.youtube.com/embed/UzhMA2Mw3Bc" title="YouTube video player" frameBorder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerPolicy="strict-origin-when-cross-origin" allowFullScreen loading="lazy"></iframe> |
1 participant
Adds the YouTube video embed to the top of the Dakota Alpha 1 blog post. Feel free to move it to a better spot.